Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #732 +/- ##
=======================================
Coverage 84.31% 84.31%
=======================================
Files 36 36
Lines 1817 1817
=======================================
Hits 1532 1532
Misses 285 285 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jj22ee
approved these changes
Nov 17, 2025
jj22ee
pushed a commit
that referenced
this pull request
Nov 28, 2025
* feat: use invoke-store from global * fix: duplicate * fix: bump @aws/lambda-invoke-store but used in devDependencies only (for testing) * fix: package-lock.json * fix: lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Previously, we introduced a breaking change in
aws/lambda-invoke-storeto allow lazy loading a costly dependency (see awslabs/aws-lambda-invoke-store#13)Now, it requires the store to be retrieved using an await operation. This change would force our callers to become async, leading to extensive refactoring and breaking changes in public-facing functions.
To maintain backward compatibility, we've updated the implementation to use
globalThis.awslambda?.InvokeStoreinstead. This approach avoids the need for async operations while still accessing the store.Test cases have been updated accordingly.
Some minor linting fix in the test file
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.